Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume configuration in docker-compose.yml #295

Conversation

admiralhr99
Copy link
Contributor

This PR addresses an issue with the volume configuration in the docker-compose.yml file. Previously, running docker compose up -d would result in the following error:

Error response from daemon: invalid mount config for type "volume": invalid mount path: 's-ui' mount path must be absolute

The fix involves:

  1. Properly defining the 'singbox' volume in the volumes section
  2. Using the correct syntax for named volumes in the service configurations

Changes made:

  • Added 'singbox:' to the volumes section at the bottom of the file
  • Updated volume references in the 's-ui' and 'sing-box' services

Testing:
I've tested this change by running docker compose up -d with the updated configuration, and the containers now start successfully without the previous error.

Let me know if any further changes or information are needed!

Copy link
Owner

@alireza0 alireza0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use docker volume for logs.

- singbox:/app/bin
- ./db:/app/db
- ./cert:/app/cert
- ./logs:/logs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs are not supposed to use PWD folder.

syslog:
image: rsyslog/syslog_appliance_alpine
container_name: syslog
volumes:
- "logs:/logs"
- ./logs:/logs
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@alireza0
Copy link
Owner

Due to release, I will close it and fix it by myself

@alireza0 alireza0 closed this Oct 29, 2024
alireza0 added a commit that referenced this pull request Oct 29, 2024
Co-authored-by: admiralhr99 <admiralhr99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants